feat: add owner check and conditional rendering for Fund component #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented owner check in the Fund component using `getOwner` from the contract. - Added conditional rendering for "Withdraw" and "Donate" buttons based on ownership and fund state. - Updated the `getDetails` function to include owner address retrieval. - Enhanced error handling for fetching fund details. - Improved user feedback with appropriate messages for different fund states.
adrianvrj
reviewed
Nov 22, 2024
| {Number(fund.state) === 2 && ( | ||
| <> | ||
| {isOwner ? ( | ||
| <p>You are the owner. Donations will go towards your funding goal.</p> |
adrianvrj
requested changes
Nov 22, 2024
Removed the p
adrianvrj
reviewed
Nov 23, 2024
There was a problem hiding this comment.
please reverse the changes to this file
adrianvrj
requested changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes [feat] Display withdraw btn only for owner #249
Commented the code
Changes description
getOwnerfrom the contract.getDetailsfunction to include owner address retrieval.Current output
Give evidence like screenshots of what your job looks like.
Time spent breakdown
Understanding Requirements and Planning(Repo structure): ~30 minutes
Implementing Owner Check and State Logic: ~1 hour
Conditional Rendering of Buttons: ~45 minutes
Refactoring getDetails Function: ~30 minutes
Comments
Super Happy to contribute to this amazing project, hope to keep contributing!!!