Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Set Contact Handle #259 #270

Merged

Conversation

ChrisFernandezVivas
Copy link
Contributor

Pull Request

  • [ x] Closes 259
  • [ x] Added tests (if necessary)
  • [x ] Run tests
  • Run formatting
  • [x ] Commented the code

Changes description

add a test for a set_contact_handle method, the test check with all authorized users and try with 1 another user, the test always fails because when another user try call the function the test fail

Current output

Captura de pantalla 2024-11-25 a las 3 45 57 p  m

Time spent breakdown

5 hours

Comments

i putted a #[should_panic] so if you remove this the test always fail

@adrianvrj adrianvrj linked an issue Nov 25, 2024 that may be closed by this pull request
Copy link
Member

@adrianvrj adrianvrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple changes from my side, did you run scarb fmt?

@adrianvrj adrianvrj requested a review from EmmanuelAR November 25, 2024 21:54
contracts/tests/test_fund.cairo Outdated Show resolved Hide resolved
Copy link
Collaborator

@EmmanuelAR EmmanuelAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adrianvrj adrianvrj merged commit 21aea84 into web3wagers:dev Nov 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test] Add test for new assert in set_contact_handle method
3 participants