Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated profile-header and breakpoint-overlay #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Gold240sx
Copy link

Why did I make this pr? After uploading my profile image, the profile object was outputting:

```
  {
    "id": 2,
    "userId": 2,
    "displayName": "Michael",
    "imageId": "946256560560...",
    "image": null,
    "bio": "<p> Hey! ..."
  }
```
I wasn't sure if uploading a seperate profile header image was what was in the works or if 
there was an error in the update to the profile image, on imageUpload, that didn't update 
the profile.image correctly, so I figured without knowing, that it should atleast show the user's 
profile.imageUrl.

Copy link

stackblitz bot commented Oct 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@Gold240sx
Copy link
Author

Ahh, I just watched the "R2 Setup" @11:20 Video, and it does indeed expect the avatar, so yes, If the user did in fact sign up with username and password, then the image would be set to undefined or null and this pull does indeed fix those cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant