-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include output operand type/rank in op constraint tables #789
Include output operand type/rank in op constraint tables #789
Conversation
Not referenced normatively, but helpful at-a-glance information. This should be redundant with existing per-op documentation.
@fdwr is this about what you were thinking? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So fast - thanks Josh.
Co-authored-by: Dwayne Robinson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@fdwr - one more look? I think we crossed the streams and you reviewed just before my last commit went in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎
Co-authored-by: Ningxin Hu <[email protected]>
…t-constraints-too
Should be good to merge when you're ready, @huningxin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SHA: d4b4e9d Reason: push, by huningxin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Not referenced normatively, but helpful at-a-glance information. This should be redundant with existing per-op documentation.
As discussed in #657 (comment)
Preview | Diff