Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include output operand type/rank in op constraint tables #789

Merged

Conversation

inexorabletash
Copy link
Member

@inexorabletash inexorabletash commented Nov 15, 2024

Not referenced normatively, but helpful at-a-glance information. This should be redundant with existing per-op documentation.

As discussed in #657 (comment)


Preview | Diff

Not referenced normatively, but helpful at-a-glance information. This
should be redundant with existing per-op documentation.
@inexorabletash
Copy link
Member Author

@fdwr is this about what you were thinking?

Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So fast - thanks Josh.

index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@inexorabletash
Copy link
Member Author

@fdwr - one more look? I think we crossed the streams and you reviewed just before my last commit went in.

Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@inexorabletash
Copy link
Member Author

Should be good to merge when you're ready, @huningxin

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@huningxin huningxin merged commit d4b4e9d into webmachinelearning:main Nov 19, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Nov 19, 2024
SHA: d4b4e9d
Reason: push, by huningxin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@inexorabletash inexorabletash deleted the output-constraints-too branch November 19, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants