Use AllowSharedBufferSource for MLGraphBuilder.constant()
#790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huningxin
commented
Nov 16, 2024
|
@a-sully , PTAL? |
a-sully
reviewed
Nov 18, 2024
huningxin
commented
Nov 21, 2024
| @@ -1503,9 +1504,6 @@ Build a composed graph up to a given output operand into a computational graph a | |||
| 1. Set |graph|.{{MLGraph/[[context]]}} to [=this=].{{MLGraphBuilder/[[context]]}}. | |||
| 1. [=set/For each=] |operand| in |inputs|: | |||
| 1. Set |graph|.{{MLGraph/[[inputDescriptors]]}}[|operand|.{{MLOperand/[[name]]}}] to |operand|.{{MLOperand/[[descriptor]]}}. | |||
|
|
|||
| Issue(566): If {{MLGraphBuilder/constant(descriptor, bufferView)|constants'}} {{ArrayBuffer}}s are not [=ArrayBuffer/transferred=], make copies for [=MLGraphBuilder/graph=]'s [=computational graph/constants=] here. | |||
There was a problem hiding this comment.
Note: this issue is closed and not relevant.
huningxin
commented
Nov 21, 2024
| </summary> | ||
| 1. If [=this=].{{MLGraphBuilder/[[hasBuilt]]}} is true, then [=exception/throw=] an "{{InvalidStateError}}" {{DOMException}}. | ||
| 1. If [=MLOperandDescriptor/checking dimensions=] given |descriptor| returns false, then [=exception/throw=] a {{TypeError}}. | ||
| 1. If [=validating buffer with descriptor=] given |bufferView| and |descriptor| returns false, then [=exception/throw=] a {{TypeError}}. | ||
| 1. If [=validating buffer with descriptor=] given |bufferSource| and |descriptor| returns false, then [=exception/throw=] a {{TypeError}}. |
There was a problem hiding this comment.
Note: This depends on #787 for supporting AllowSharedBufferSource in "validate buffer with descriptor" algorithm.
huningxin
changed the title
MLGraphBuilder.constant()AllowSharedBufferSource for MLGraphBuilder.constant()
a-sully
reviewed
Nov 21, 2024
| @@ -1341,7 +1341,8 @@ interface MLGraphBuilder { | |||
| MLOperand input(USVString name, MLOperandDescriptor descriptor); | |||
|
|
|||
| // Create an operand for a graph constant. | |||
| MLOperand constant(MLOperandDescriptor descriptor, ArrayBufferView bufferView); | |||
| MLOperand constant(MLOperandDescriptor descriptor, | |||
| AllowSharedBufferSource bufferSource); | |||
There was a problem hiding this comment.
What do you think about just using buffer, at least in the IDL?
Suggested change
| AllowSharedBufferSource bufferSource); | |
| AllowSharedBufferSource buffer); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #788
Preview | Diff