Minor refactor

webpro-nl · Apr 19, 2024 · 4a49277 · 4a49277
1 parent 9666877
commit 4a49277
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 17 deletions.
diff --git a/packages/knip/src/util/array.ts b/packages/knip/src/util/array.ts
@@ -6,3 +6,9 @@ export const compact = <T>(collection: Collection<T | undefined>) =>
 
 export const arrayify = (value?: string[] | string) =>
   Array.isArray(value) ? value : typeof value === 'string' ? [value] : [];
+
+export const partition = <T>(collection: T[], predicate: (item: T) => unknown) => {
+  const results: [T[], T[]] = [[], []];
+  for (const item of collection) results[predicate(item) ? 0 : 1].push(item);
+  return results;
+};
diff --git a/packages/knip/src/util/map-workspaces.ts b/packages/knip/src/util/map-workspaces.ts
@@ -1,18 +1,13 @@
 import fastGlob from 'fast-glob';
 import type { Package } from '../ConfigurationChief.js';
 import type { PackageJson } from '../types/package-json.js';
+import { partition } from './array.js';
 import { debugLog } from './debug.js';
 import { ConfigurationError } from './errors.js';
 import { getPackageName } from './package-name.js';
 import { join } from './path.js';
 import { _require } from './require.js';
 
-const partition = <T>(collection: T[], predicate: (item: T) => unknown) => {
-  const results: [T[], T[]] = [[], []];
-  for (const item of collection) results[predicate(item) ? 0 : 1].push(item);
-  return results;
-};
-
 export default async function mapWorkspaces(cwd: string, workspaces: string[]) {
   const [negatedPatterns, patterns] = partition(workspaces, p => p.match(/^!+/));
   const byPkgDir = new Map<string, Package>();

diff --git a/packages/knip/src/util/tag.ts b/packages/knip/src/util/tag.ts
@@ -1,16 +1,16 @@
 import type { Tags } from '../types/cli.js';
 
-export const splitTags = (tags: string[]) =>
-  tags
-    .flatMap(tag => tag.split(','))
-    .reduce<Tags>(
-      ([incl, excl], tag) => {
-        const match = tag.match(/[a-zA-Z]+/);
-        if (match) (tag.startsWith('-') ? excl : incl).push(match[0]);
-        return [incl, excl];
-      },
-      [[], []]
-    );
+export const splitTags = (rawTags: string[]) => {
+  const tags = rawTags.flatMap(tag => tag.split(','));
+  return tags.reduce<Tags>(
+    ([incl, excl], tag) => {
+      const match = tag.match(/[a-zA-Z]+/);
+      if (match) (tag.startsWith('-') ? excl : incl).push(match[0]);
+      return [incl, excl];
+    },
+    [[], []]
+  );
+};
 
 const hasTag = (tags: string[], jsDocTags: Set<string>) => tags.some(tag => jsDocTags.has(`@${tag}`));