-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: init k3s ansible playbook #1071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shrinks99
reviewed
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor docs fixes for parity with #1091
Chickensoupwithrice
force-pushed
the
ansible-k3s
branch
from
August 24, 2023 00:20
30cf045
to
aac1d67
Compare
ikreymer
reviewed
Aug 26, 2023
ikreymer
reviewed
Aug 30, 2023
ikreymer
reviewed
Aug 30, 2023
ikreymer
reviewed
Sep 1, 2023
ikreymer
reviewed
Sep 1, 2023
ikreymer
reviewed
Sep 1, 2023
ikreymer
reviewed
Sep 1, 2023
ikreymer
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this and can further iterate on the docs in the follow-up PRs.
It changes the directory layout of the ansible playbook to a more "best practices" friendly approach using ansible roles and a real inventory file Co-authored-by: Ilya Kreymer <[email protected]>
Chickensoupwithrice
force-pushed
the
ansible-k3s
branch
from
September 5, 2023 21:29
b018c8f
to
a32d69a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn key browsertrix-cloud deployment on k3s for local, single-node and multi-node deployments using
ingress-nginx
through ansible playbooks.Resolves #1029
It changes the directory layout of the ansible playbook to a more "best practices" friendly approach using ansible roles and a real inventory file. No more huge arg list while deploying.
This does bring in the problem of merging with our current playbook. Specifically in order to run the playbook, currently it requires
install-k3s
to be copied out of theplaybooks
dir. It doesn't interfere with current deployment practices, but at some point down the line I'd like to refactor the microk8s deployment to follow this directory structure. Another addition further down the line could be incorporating the current DO deployment into thebtrix
role which would complete the playbook transformation and make it much more maintainable (regardless of deployment strategy, they'd all use thebtrix
role)Todo: