Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browsertrix Cloud → Browsertrix frontend text rename #1466

Merged
merged 12 commits into from
Mar 12, 2024

Conversation

Shrinks99
Copy link
Member

@Shrinks99 Shrinks99 commented Dec 22, 2023

Part of #1241

Changes

  • Renames all instances of "Browsertrix Cloud" to "Browsertrix" on the front end.

Caveats

  • Does not edit the docs, will follow up in a future PR.
    • Actually this DOES change the docs now!

@Shrinks99 Shrinks99 added the front end Requires front end dev work label Dec 22, 2023
@Shrinks99 Shrinks99 self-assigned this Dec 22, 2023
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I'm wondering if we should put a note in the README (maybe down at the bottom) explaining that the project used to be call "Browsertrix Cloud"?

Are we going to rename the repo as well?

@Shrinks99
Copy link
Member Author

The repo would be renamed (actually back to its previous name!)

As for the readme, ehh, those types of notes stick around for a while and get stale? I think folks will figure it out?

@Shrinks99 Shrinks99 requested review from emma-sg and tw4l March 6, 2024 21:34
@emma-sg

This comment was marked as resolved.

@emma-sg emma-sg force-pushed the frontend-browsertrix-rename branch from da961b2 to 85fece4 Compare March 7, 2024 22:07
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Not sure how if we'd want to consider email content to be frontend or not, but that would also be a pretty quick change — that's just chart/email-templates/invite and chart/email-templates/validate. Happy to merge without though, and address that in a followup PR!

@Shrinks99
Copy link
Member Author

Merging to start updating other brand assets

@Shrinks99 Shrinks99 merged commit 8ba29ca into main Mar 12, 2024
6 checks passed
@Shrinks99 Shrinks99 deleted the frontend-browsertrix-rename branch March 12, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front end Requires front end dev work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants