ES Module support #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 tasks
|
@hailiang-wang Please help this PR to fix the |
|
ping @hailiang-wang |
|
Because the https://github.com/chatopera/chatopera-nodejs-sdk has been disabled the issue function, so I leave the reason here: After inspecting the source code of I hope it can be resolved because it is breaking the importing code in the downstream TS programs. |
|
@mukaiu Could you please help us to review this PR, and if it's OK let's move on to merge it? Thank you very much! |
mukaiu
reviewed
Oct 25, 2021
| RepoConfig, | ||
| ChatoperaOptions, | ||
| ChatoperaResponse, | ||
| } from './chatopera' | ||
| } from './chatopera.js' | ||
|
|
||
| import { |
There was a problem hiding this comment.
New code, need to add file extension.
mukaiu
reviewed
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to:
Issues:
ChatOperaexport from@chatopera/sdkSee:
https://github.com/wechaty/wechaty-chatopera/blob/45fb0a43e0fbf4e5d19c2cf2c8db19de7f55ada8/src/asker.ts#L12-L15