New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor weight combination schemes #30

Closed

wehs7661 wants to merge 1 commit into master from refactor_w_combine

Owner

wehs7661 commented Nov 1, 2023 •

edited

Loading

This PR aims to address issue #29, which includes the following tasks:

Removing the functionality relevant to rmse_cutoff
Removing the option final from the YAML parameter w_combine
Deprecating the schemes of multiple swaps.

For the reason why these functionalities are removed/deprecated, please refer to the issue.


          Removed rmse_cutoff

134f9f6

wehs7661 self-assigned this

wehs7661 added enhancement documentation labels

Owner Author

wehs7661 commented Nov 1, 2023

Closing the PR since it might be easier to merge the master branch first.

wehs7661 closed this

wehs7661 deleted the refactor_w_combine branch

November 1, 2023 16:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation enhancement