Obsolete TODOs

well-typed · Oct 25, 2024 · 8ee46de · 8ee46de
1 parent c501e76
commit 8ee46de
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 5 deletions.
diff --git a/grapesy/src/Network/GRPC/Client/Session.hs b/grapesy/src/Network/GRPC/Client/Session.hs
@@ -109,8 +109,6 @@ instance SupportsClientRpc rpc => InitiateSession (ClientSession rpc) where
           case verifyAllIf connVerifyHeaders responseHeaders of
             Left  err  -> throwIO $ CallSetupInvalidResponseHeaders err
             Right hdrs -> do
-              -- TODO: <https://github.com/well-typed/grapesy/issues/203>
-              -- If we omit this call to 'updateConnectionMeta', no tests fail.
               Connection.updateConnectionMeta conn responseHeaders
               cIn <- getCompression $ requiredResponseCompression hdrs
               return $ FlowStartRegular $ InboundHeaders {

diff --git a/grapesy/src/Network/GRPC/Util/Session/Channel.hs b/grapesy/src/Network/GRPC/Util/Session/Channel.hs
@@ -141,9 +141,6 @@ data RegularFlowState flow = RegularFlowState {
       -- This TMVar is written to for incoming messages ('recvMessageLoop') and
       -- read from for outgoing messages ('sendMessageLoop'). It acts as a
       -- one-place buffer, providing backpressure in both directions.
-      --
-      -- TODO: <https://github.com/well-typed/grapesy/issues/118>.
-      -- It might make sense to generalize this to an @N@-place buffer.
     , flowMsg :: TMVar (StreamElem (Trailers flow) (Message flow))
 
       -- | Trailers