Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for #257 #259

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Add test for #257 #259

merged 1 commit into from
Dec 17, 2024

Conversation

edsko
Copy link
Collaborator

@edsko edsko commented Nov 16, 2024

The problem is fixed in latest http2
(7036a3429fb08bfcd5947230c37d1f3e63dfb3a6). See kazu-yamamoto/http2#151 for the http2 bug report.

Closes #257.

We can merge this once the latest http2 is released (after updating the lower bound).

@edsko edsko marked this pull request as draft November 16, 2024 10:18
@edsko edsko force-pushed the edsko/reclamation branch from ab47c7d to b05cfe3 Compare November 19, 2024 09:39
@edsko edsko marked this pull request as ready for review November 19, 2024 09:39
@edsko edsko force-pushed the edsko/reclamation branch 2 times, most recently from f2cede8 to 986311b Compare November 23, 2024 07:56
@edsko
Copy link
Collaborator Author

edsko commented Nov 23, 2024

We should probably for wait kazu-yamamoto/http2#155 to be merged and released.

@edsko edsko force-pushed the edsko/reclamation branch 3 times, most recently from 3612184 to ed8ac62 Compare November 29, 2024 10:03
@edsko
Copy link
Collaborator Author

edsko commented Nov 29, 2024

Tests pass with http2 5.3.8, but we're seeing a lot of TimeoutThread exceptions; see discussion in kazu-yamamoto/http2#155 . I also saw one stress test fail with "resource vanished", not sure if that's a regression is whether there is some non-determinism there.

@edsko edsko force-pushed the edsko/reclamation branch 2 times, most recently from f48a333 to e3b00f9 Compare December 4, 2024 14:48
@edsko
Copy link
Collaborator Author

edsko commented Dec 4, 2024

Note that support for ghc 9.10 for the demos is basically blocked on haskell/cabal#6522 , or else updates to proto-lens and proto-lens-runtime, which is more likely.

@edsko
Copy link
Collaborator Author

edsko commented Dec 4, 2024

Merging of this PR is blocked only on yesodweb/wai#1016 (and corresponding release) now.

The problem is fixed in latest `http2`
(`7036a3429fb08bfcd5947230c37d1f3e63dfb3a6`).  See
kazu-yamamoto/http2#151 for the `http2` bug report.

Closes #257.
@edsko edsko force-pushed the edsko/reclamation branch from e3b00f9 to 9cf465d Compare December 17, 2024 12:43
@edsko edsko merged commit bf74f47 into main Dec 17, 2024
6 checks passed
@edsko edsko deleted the edsko/reclamation branch December 17, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arbitrary.WithExceptions: Too many open files
1 participant