Use lexical binding in utils.el
#28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`add-to-list` can't be used with lexical binding, which is probably
why its documentation discourages the use. So replace this with `push`
Fixes compilation error:
In refman2func-doc:
utils.el:29:12: Error: ‘add-to-list’ can’t use lexical var ‘functions’; use ‘push’ or ‘cl-pushnew’
Upstream Emacs has enabled warnings for `.el` files with no
lexical-binding directive, so this file triggers a:
In toplevel form:
lsp.el:1:1: Warning: file has no ‘lexical-binding’ directive on its first line
Fix that.
|
Thank you. I'll merge this to get rid of the warning. However, this code is probably not much useful nowadays, since the format of the reference documentation, which this code should "parse", has changed. |
|
Yeah, I too didn't find the file the function was referring to in Meson sources. But I didn't even find it in the history, so I wasn't sure if it's still useful (e.g. to parse some other file), so decided to leave it as is. Btw, I was just working on fixing yet another warning 😅 Will send as a separte PR then, it should be the last one present in meson-mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream Emacs has enabled warnings for
.elfiles with no lexical-binding directive, so this file triggers a:Fix that.