-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic Highlight Improvement for Python #233 #235
base: master
Are you sure you want to change the base?
Conversation
Please check new commit 67c0e94 |
@SmitAkbari26 Could you please wait for a moment before I spare my time to push my commits? I have made some enhancements for Python semantic highlighting which are also harmless to other languages. You can check the feature in semantic-highlight-guide. |
@Eitheages Ohk i will close mine new pull request and add your new commit. |
@SmitAkbari26 You can check my commits here. I'd love to keep communication with you! |
@Eitheages I am glad to here that i will check your commit and let you know. |
@SmitAkbari26 But it reminds me that I should consider the scenario when semantic highlighting is disabled. I've reverted your previous PR (#223) (forgive the possible impolicy), so the problem above occurs again. I'll try to fix it when I'm available again! |
@Eitheages Ohk. Try to solve error and send me latest commit you make i will check it. |
@SmitAkbari26 May I commit on your branch tip? |
@@ -15,8 +15,7 @@ | |||
}, | |||
"type": { | |||
// "foreground": "#ff0088", | |||
"foreground": "#FF68B8", | |||
"italic": true | |||
"foreground": "#FF68B8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we can do this, as this change will affect all languages not just Python.
I opened my PR #236. |
Apologies for the delayed response, as I haven't been actively checking GitHub lately.
I solve this
self
parameter lose its highlight when semantic tokens are enabled issue and create new pull request please check new pull request and let me know.