Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic Highlight Improvement for Python #233 #235

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SmitAkbari26
Copy link
Contributor

Apologies for the delayed response, as I haven't been actively checking GitHub lately.

image

I solve this self parameter lose its highlight when semantic tokens are enabled issue and create new pull request please check new pull request and let me know.

image

@SmitAkbari26
Copy link
Contributor Author

Please check new commit 67c0e94
@wesbos @palashmon

@rennsax
Copy link
Contributor

rennsax commented Aug 20, 2023

@SmitAkbari26 Could you please wait for a moment before I spare my time to push my commits? I have made some enhancements for Python semantic highlighting which are also harmless to other languages. You can check the feature in semantic-highlight-guide.

@SmitAkbari26
Copy link
Contributor Author

@Eitheages Ohk i will close mine new pull request and add your new commit.

@rennsax
Copy link
Contributor

rennsax commented Aug 20, 2023

@SmitAkbari26 You can check my commits here. I'd love to keep communication with you!

@SmitAkbari26
Copy link
Contributor Author

@Eitheages I am glad to here that i will check your commit and let you know.

@SmitAkbari26
Copy link
Contributor Author

@Eitheages,
Your change is good but it got same issue which i previously solved and merge it.
This is look after i solve issue
image

And with your change it create same issue which previously have
image

@rennsax
Copy link
Contributor

rennsax commented Aug 20, 2023

@SmitAkbari26
Maybe you can open semantic token feature? This could happen if VS Code doesn't recognize the word as a valid function/property. I always open my Pylance extension and enable semantic highlighting.

But it reminds me that I should consider the scenario when semantic highlighting is disabled. I've reverted your previous PR (#223) (forgive the possible impolicy), so the problem above occurs again.

I'll try to fix it when I'm available again!

@SmitAkbari26
Copy link
Contributor Author

@Eitheages Ohk. Try to solve error and send me latest commit you make i will check it.

@rennsax
Copy link
Contributor

rennsax commented Aug 21, 2023

@SmitAkbari26 May I commit on your branch tip?

@@ -15,8 +15,7 @@
},
"type": {
// "foreground": "#ff0088",
"foreground": "#FF68B8",
"italic": true
"foreground": "#FF68B8"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we can do this, as this change will affect all languages not just Python.

@rennsax
Copy link
Contributor

rennsax commented Aug 22, 2023

I opened my PR #236.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants