imprv: display page tree in page select modal with scrollbar #8514
+43
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WNomunomu
commented
Feb 26, 2024
| <div | ||
| id="grw-page-select-modal-wrapper" | ||
| className={`${styles['tree-for-modal-wrapper']} overflow-y-scroll`} | ||
| style={{ height: '50vh' }} |
There was a problem hiding this comment.
このheightについては、fumiya-sと相談して決めました。
There was a problem hiding this comment.
height: '50vh' も PageSelectModal.module.scss に書いていいと思います
miya
reviewed
Feb 26, 2024
| <div | ||
| id="grw-page-select-modal-wrapper" | ||
| className={`${styles['tree-for-modal-wrapper']} overflow-y-scroll`} | ||
| style={{ height: '50vh' }} |
There was a problem hiding this comment.
height: '50vh' も PageSelectModal.module.scss に書いていいと思います
| @@ -0,0 +1,3 @@ | |||
| .tree-for-modal-wrapper::-webkit-scrollbar { | |||
There was a problem hiding this comment.
-webkit-scrollbar が非推奨らしいのだけどこれでいいのかな？
https://developer.mozilla.org/ja/docs/Web/CSS/::-webkit-scrollbar
…-PageSelectModal-with-scrollbar
|
reg-suit detected visual differences. Check this report, and review them. 🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴 What do the circles mean?The number of circles represent the number of changed images.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
miya
reviewed
Feb 27, 2024
| @@ -0,0 +1,3 @@ | |||
| .grw-page-select-modal-wrapper { | |||
| height: 50vh; | |||
| } | |||
There was a problem hiding this comment.
PageSelectModalのPageSelectModalWrapperコンポーネントのheightを設定するために使っています。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
タスク
https://redmine.weseek.co.jp/issues/140833
概要
変更点
xd
https://xd.adobe.com/view/26f3cef5-06c1-4ed2-9871-b86d5d00adce-73a0/screen/374cb579-53cf-4856-8132-ed7cdf91c157/
スクリーンショット
セルフチェック