Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support: @uiw/react-codemirror in apps/app #9431

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

miya
Copy link
Member

@miya miya commented Nov 22, 2024

Task

https://redmine.weseek.co.jp/issues/157921

やったこと

トピックブランチ (#8984) で以下のエラーが出ていたためその修正

Error: src/client/components/PageEditor/PageEditorMainSwitcher.tsx(9,43): error TS2307: Cannot find module '@uiw/react-codemirror' or its corresponding type declarations.

https://github.com/weseek/growi/actions/runs/11954764874/job/33325627913?pr=8984#step:7:1140

@miya miya requested a review from yuki-takei November 22, 2024 09:24
@miya miya self-assigned this Nov 22, 2024
Copy link

changeset-bot bot commented Nov 22, 2024

⚠️ No Changeset found

Latest commit: c90ee6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@miya miya changed the title support: @uiw/react-codemirror in apps/app support: @uiw/react-codemirror in apps/app Nov 22, 2024
@yuki-takei yuki-takei merged commit 9610ab8 into feat/non-yjs-mode Nov 22, 2024
13 checks passed
@yuki-takei yuki-takei deleted the support/uiw/react-codemirror branch November 22, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants