-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Replace opaque test harness workflows with explicit workflow implementation #294
Open
MaisenbacherD
wants to merge
12
commits into
westerndigitalcorporation:master
Choose a base branch
from
MaisenbacherD:ci-opaque-runner
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CI: Replace opaque test harness workflows with explicit workflow implementation #294
MaisenbacherD
wants to merge
12
commits into
westerndigitalcorporation:master
from
MaisenbacherD:ci-opaque-runner
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the zenfs-test-harness releated lines with the concrete implementation of the somke-test test case. Signed-off-by: Dennis Maisenbacher <[email protected]> Co-authored-by: Andreas Hindborg <[email protected]>
Replace the zenfs-test-harness releated lines with the concrete implementation of the somke-test-debug test case. Signed-off-by: Dennis Maisenbacher <[email protected]> Co-authored-by: Andreas Hindborg <[email protected]>
Replace the zenfs-test-harness releated lines with the concrete implementation of the zbdbench test case. Signed-off-by: Dennis Maisenbacher <[email protected]> Co-authored-by: Andreas Hindborg <[email protected]>
Replace the zenfs-test-harness releated lines with the concrete implementation of the short-performance test case. Signed-off-by: Dennis Maisenbacher <[email protected]> Co-authored-by: Andreas Hindborg <[email protected]>
Replace the zenfs-test-harness releated lines with the concrete implementation of the short-performance-xfs test case. Signed-off-by: Dennis Maisenbacher <[email protected]> Co-authored-by: Andreas Hindborg <[email protected]>
Signed-off-by: Dennis Maisenbacher <[email protected]>
Replace the zenfs-test-harness releated lines with the concrete implementation of the rocks-nightly test case. Signed-off-by: Dennis Maisenbacher <[email protected]> Co-authored-by: Andreas Hindborg <[email protected]>
Replace the zenfs-test-harness releated lines with the concrete implementation of the percona-server-smoke-test test case. Signed-off-by: Dennis Maisenbacher <[email protected]> Co-authored-by: Andreas Hindborg <[email protected]>
Replace the zenfs-test-harness releated lines with the concrete implementation of the long-performace test case. Signed-off-by: Dennis Maisenbacher <[email protected]> Co-authored-by: Andreas Hindborg <[email protected]>
Replace the zenfs-test-harness releated lines with the concrete implementation of the long-performance-xfs test case. Signed-off-by: Dennis Maisenbacher <[email protected]> Co-authored-by: Andreas Hindborg <[email protected]>
MaisenbacherD
force-pushed
the
ci-opaque-runner
branch
from
August 27, 2024 04:19
620aa55
to
6890e57
Compare
Fixes #288 |
Replace the zenfs-test-harness releated lines with the concrete implementation of the mtr-test test case. Signed-off-by: Dennis Maisenbacher <[email protected]> Co-authored-by: Andreas Hindborg <[email protected]>
API change with RocksDB v9.0.0 removes default implementation of `FSWritableFile::GetFileSize`. We therefore need to implement `ZonedWriteableFile::GetFileSize`. Signed-off-by: Dennis Maisenbacher <[email protected]>
MaisenbacherD
force-pushed
the
ci-opaque-runner
branch
from
August 28, 2024 08:02
6890e57
to
2230e12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to replace the opaque legacy zenfs test harness with concrete workflow implementations.
This is a requirement for adopting a new self-hosted GitHub runner infrastructure (which we need because of the ZNS devices on which we want to run our tests).
The new self-hosted GitHub runner IaC is to be open-sourced.
Requirements for this self-hosted runner:
necessary ports.
after each workflow run.
ssh is just allowed from local IPs, https is just allowed to and from
external addresses (no access to internal cluster services), access to VM
image repository access just from local IPs.
only allow sshd access from cluster local IPs into the VM.
Configuration required by the GitHub repo that uses the self-hosted runner:
one repository
Repo -> Settings -> Actions -> General -> Actions permissions
Repo -> Settings -> Actions -> General -> 'Require approval for all outside
collaborators' -> Save
Repo -> Settings -> Actions -> General -> 'Read repository content and packages
permissions' -> Save
GITHUB_TOKEN:
Repo -> Settings -> Actions -> General -> DISABLE 'Allow GitHub Actions to
create and approve pull requests' -> Save
(https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions)
In a GitHub workflow that uses a container, the block device has to be passed
into the container: