Fix DB migration

westonganger · Oct 17, 2023 · 2273cf3 · 2273cf3
1 parent 10f6859
commit 2273cf3
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/lib/generators/active_snapshot/install/templates/create_snapshots_tables.rb.erb b/lib/generators/active_snapshot/install/templates/create_snapshots_tables.rb.erb
@@ -15,7 +15,8 @@ class <%= migration_name %> < ActiveRecord::Migration::Current
 
     create_table :snapshot_items<%= table_options %> do |t|
       t.belongs_to :snapshot, null: false, index: true
-      t.belongs_to :item, polymorphic: true, null: false, unique: [:snapshot_id], index: true
+      t.belongs_to :item, polymorphic: true, null: false, index: true
+      t.index [:snapshot_id, :item_id, :item_type], unique: true
 
       t.<%= ActiveSnapshot.config.storage_method == 'native_json' ? 'json' : 'text' %> :object, null: false
 

diff --git a/test/dummy_app/db/migrate/20210306100122_create_snapshots_tables.rb b/test/dummy_app/db/migrate/20210306100122_create_snapshots_tables.rb
@@ -8,16 +8,25 @@ def change
       t.string :identifier, index: true
       t.index [:identifier, :item_id, :item_type], unique: true
 
-      t.<%= ActiveSnapshot.config.storage_method == 'native_json' ? 'json' : 'text' %> :metadata, null: false
+      if ActiveSnapshot.config.storage_method == 'native_json'
+        t.json :metadata, null: false
+      else
+        t.text :metadata, null: false
+      end
 
       t.datetime :created_at, null: false
     end
 
     create_table :snapshot_items do |t|
       t.belongs_to :snapshot, null: false, index: true
-      t.belongs_to :item, polymorphic: true, null: false, unique: [:snapshot_id], index: true
+      t.belongs_to :item, polymorphic: true, null: false, index: true
+      t.index [:snapshot_id, :item_id, :item_type], unique: true
 
-      t.<%= ActiveSnapshot.config.storage_method == 'native_json' ? 'json' : 'text' %> :object, null: false
+      if ActiveSnapshot.config.storage_method == 'native_json'
+        t.json :object, null: false
+      else
+        t.text :object, null: false
+      end
 
       t.datetime :created_at, null: false
       t.string :child_group_name