Maintenance PR

[12people]

Various minor fixes, partly to get the project to build on macOS with the latest version of Flutter, partly to fix lint warnings.

All changes are annotated in the relevant commits.

[12people]

The CI tests all fail because they use an old Dart version.
Could the Dart SDK for those checks be updated?

[12people]

I also added new icons for all platforms.
iOS now has sharper (but optimized via optipng) icons, macOS now has squircle icons, as is the norm on latest macOS versions, and Android now has a vector-based icon, which also serves as a monochrome icon (solving the problem that is mentioned in #442 ).

[rolandgeider]

Cool, thanks!

Yeah, we need to finish work on fix/replace-chart-lib, the old chart lib was discontinued and is preventing us from updating flutter to something not old, but it's just some polishing left (#433)

[rolandgeider]

and Android now has a vector-based icon, which also serves as a monochrome icon (solving the problem that is mentioned in #442 ).

aweome, will check it out

[12people]

Cool, thanks!

Yeah, we need to finish work on fix/replace-chart-lib, the old chart lib was discontinued and is preventing us from updating flutter to something not old, but it's just some polishing left (#433)

Oh, what I did was just replace it with the community-maintained fork: community_charts_flutter. It's basically a drop-in replacement.

I do agree, though, that using fl_charts is probably best in the long run.

[rolandgeider]

BTW, how did you generate the images? We were (or rather, used once) the flutter_launcher_icons package

[12people]

@rolandgeider Manually.

I made a template for app icons in Figma for myself, which I've used for all my projects and it was easy to just plug the wger icon into that too.

Figma lets you specify multiple export sizes as well as suffixes, so once you've got that set up in Figma, getting the iOS and macOS icons is just a simple matter of dragging those exports into the right folder. For Android, I exported an SVG for the foreground and converted that into an Android Drawable via Android Studio.

(I didn't update any of the old Android PNGs, as that would require manually renaming each exported PNG and dragging it into the right folder — while Figma supports specifying export prefixes and suffixes, it does not support specifying different folders for each export, so it's not quite as simple to generate PNG icons for Android. I suppose you could write an automated script for this, but a vector version works well enough for everything v26 and onward, so I didn't see a need to.)

[rolandgeider]

so if/when we change the target sdk to 26 we could remove the android png icons, right?

[12people]

so if/when we change the target sdk to 26 we could remove the android png icons, right?

Sure.

That said, the vector drawable in the PR is used automatically for all platforms 26 and above, so the PNGs only serve as fallback for older platforms.

[rolandgeider]

👍🏻

yeah, that's what I meant. I think at the moment we have something lower than that, like 23 or so

[rolandgeider]

Merged thanks :)