Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RenderOverFlex Error on DashBoard Screen For Measurement Graphs #663

Merged
merged 7 commits into from
Nov 7, 2024

Conversation

ARYPROGRAMMER
Copy link
Contributor

Description

This PR Fixes a Minor UI Bug where the Measurements Widget in the Dashboard screen has a RenderOverFlow error when launching the app on a different Res Screen

Link to the issue :

  • Found while running, No existing Issue

Tests

  • Not Needed as No Core Functionalities are Affected

Checklist

  • Set a 100 character limit in your editor/IDE to avoid white space diffs in the PR
  • Tests for the changes have been added (for bug fixes / features)
  • Added yourself to AUTHORS.md
  • Updated/added relevant documentation (doc comments with ///).
  • Added relevant reviewers.

Additional Notes (NOT Relavant to PR) :

I found a lot of bugs while inspecting the App, Some of them are :

  • Delete and Create BodyWeightEntries do no update the UI instantly
  • The Time Glitch should be solved by including precision to hour and minutes Learn More
  • The Backend has an incorrect logic for implementing WorkoutRoutine Timing save Learn More

@ARYPROGRAMMER
Copy link
Contributor Author

@rolandgeider please review and merge this bug fix

@rolandgeider rolandgeider merged commit 0a40758 into wger-project:master Nov 7, 2024
1 check passed
@rolandgeider
Copy link
Member

Merged, thanks! As for the other things, you are right that we should definitely do some polishing / refactoring on a couple of places, I'm having some free days next week so let's see how far we get (and if you want to do a couple, feel free to do so 😅 )

@Dieterbe
Copy link
Contributor

Dieterbe commented Nov 8, 2024

embedding a single widget inside a singlechildscrollview is quite an suboptimal "solution", especially since the page as a whole is also a singlechildscrollview.

when did you see the overflow? was it only when the title needed more than 1 line? we could probably solve that much cleaner by constraining (cutting off) the text to just use 1 line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants