Plate 46 calc #688
Plate 46 calc #688
Conversation
|
thanks for the PR, I'll review it next week |
| plateProvider.setWeight(num.parse(_weightController.text)); | ||
| Navigator.of(context).push(MaterialPageRoute(builder: (context)=>const AddPlateWeights())); | ||
| }, | ||
| child: const Text("Enter custom Denomination's") |
There was a problem hiding this comment.
I would make this a bit less prominent, a gear icon left to "Plates" would probably be enough
| appBar: AppBar ( | ||
| title: const Text('Enter Custom Plate Weights'), | ||
| ), | ||
| body: Column ( |
There was a problem hiding this comment.
make sure there is enough margin on the right side of the screen as well (or wrap around if there's not enough space). Also I would name the dropdown something like "preferred unit". If you want, you can extract this info from the profile from the UserProvider (the isMetric).
| notifyListeners(); | ||
| } | ||
|
|
||
| void toggleSelection(num x) { |
There was a problem hiding this comment.
I would save the selected weights to the device, then we don't need to add this every time. You can simply save the array to SharedPreferences (just dump it as a string and later read from that)
There was a problem hiding this comment.
I am encountering difficulties in calculating plate denominations using the saved plate weight denominations while implementing shared preferences.
I've explored several approaches:
Async Function in initState(): I attempted to call an async function containing await loadFromSharedPref() within the initState() of my widget. However, this resulted in widget.getPlates executing before loadFromSharedPref(), leading to an empty list being displayed initially but it is being shown inside the slider selection menu.
Calling loadFromSharedPref() from main(): I tried calling loadFromSharedPref() from the main() function to ensure it executed before widget.getPlates. While this successfully loaded and printed the saved values in the main() function, the widget.getPlates still displayed an empty list but it is being shown inside the slider selection menu.
Flag in PlateWeightsProvider: I introduced a flag (loadedFromSharedPref) within the PlateWeightsProvider, setting it to true after loadFromSharedPref() completes. In widget.getPlates, I attempted to wait for the flag to become true before displaying the plate denominations. Unfortunately, this approach also failed to display the saved results correctly, and I'm now unable to select/deselect any options or reset them.
I've attached screenshots of the relevant functions for further clarity.
I would greatly appreciate any guidance or suggestions on how to effectively load and display shared preferences within my PlateWeightsProvider and ensure proper functionality within my widgets.
Screen.Recording.2024-12-22.at.4.36.30.PM.mov
There was a problem hiding this comment.
mhh, hadn't thought this would cause problems. I'll take a look!
|
|
||
| class PlateWeights extends ChangeNotifier{ | ||
| String unitOfPlate = 'kg'; | ||
| bool flag = false; |
There was a problem hiding this comment.
what does this do? Probably needs a better name ;)
| } else { | ||
| selectedWeights.add(x); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
aren't the if and else branches the same? :D
In this respect, I think the different variables could be simplified, e.g.having always totalWeight and totalWeightKg seems redundant.
| return Consumer<PlateWeights> ( | ||
| builder:(context,plateProvider,child)=> Scaffold ( | ||
| appBar: AppBar ( | ||
| title: const Text('Enter Custom Plate Weights'), |
There was a problem hiding this comment.
Perhaps "Select available plates" would be better. Also, all user-facing strings should be translatable (this also applies for the buttons below, for those there should be already strings).
For this, just add the string to app_en.arb and then you can just use them with AppLocalizations.of(context).<yourKey>; (sometimes the IDE gets a bit confused or doesn't catch up immediately and you'll have to insert the import manually or it will mark the key as not existing, even if it does)
| SingleChildScrollView ( | ||
| scrollDirection: Axis.horizontal, | ||
| child: Row ( | ||
| children: plateProvider.unitOfPlate == 'kg' |
There was a problem hiding this comment.
both branches are basically the same, you can just do plateProvider.unitOfPlate == 'kg' ? '$number kg' : '$number lbs' within the Text widget
| padding: const EdgeInsets.all(16), | ||
| decoration: BoxDecoration ( | ||
| color: plateProvider.selectedWeights.contains(number) | ||
| ? const Color.fromARGB(255, 82, 226, 236) |
There was a problem hiding this comment.
instead of hard coding a color, I would use something from the Theme, then this will also automatically work on the dark mode. There should be something in Theme.of(context).colorScheme suitable for this
| import 'package:wger/helpers/gym_mode.dart'; | ||
|
|
||
| class PlateWeights extends ChangeNotifier{ | ||
| String unitOfPlate = 'kg'; |
There was a problem hiding this comment.
I think a boolean would be better here, something like isMetric, then we don't have to use magic strings in the code, which will avoid mistakes like e.g. writing "Lb"
Description (Proposed Changes)
-Allow users to input their preferred bar weight and available plate weights in both kilograms and pounds.
-Calculate the optimal plate combination for a given target weight, considering the user's custom bar and plate weights.
Link to the issue : #46