POWERSYNC prototype: add migration to create postgresql publication #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dieterbe
commented
Aug 2, 2024
This is needed since the move to vite on the react side
This wasn't working well with when used over the API
This still needs to be clean up (specially the key generation, at the moment we use a new dependency, but all this can be also done with the library we currently use)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| try: | ||
| return JsonResponse({'token': token, 'powersync_url': settings.POWERSYNC_URL}, status=200) | ||
| except Exception as e: | ||
| return JsonResponse({'error': str(e)}, status=500) |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 2 months ago
To fix the problem, we need to ensure that detailed exception messages are not exposed to the end user. Instead, we should log the detailed error message on the server and return a generic error message to the client. This can be achieved by modifying the exception handling in the get_powersync_token function.
- Import the
loggingmodule if not already imported. - Replace the line that returns the detailed error message with a line that logs the error and returns a generic error message.
Suggested changeset
1
wger/core/api/views.py
| @@ -457,3 +457,4 @@ | ||
| except Exception as e: | ||
| return JsonResponse({'error': str(e)}, status=500) | ||
| logging.error(f'Error in get_powersync_token: {str(e)}') | ||
| return JsonResponse({'error': 'An internal error has occurred.'}, status=500) | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
most convenient and should be just fine
This is only needed because powersync can't handle joins
This reverts commit c6163de.
- move create publication to core - use ivm entries for the nutrition publications
# Conflicts: # wger/core/static/react/main.js
This is needed in the flutter app to properly be able to set IDs on device, since the regular IDs can only be set by postgres.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.