Bengali Language added #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeauBouchard
merged commit 7cdcd56
into
wh-iterabb-it:i18n/bengali
2 of 5 checks passed
BeauBouchard
added a commit
that referenced
this pull request
Sep 21, 2023
* Bengali Language added (#320) * few facts are translated * test cases added. test the test cases first * more facts translated * 5 more facts translated * fix: small linting fix and test assertion change --------- Co-authored-by: DShaw0004 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes for Review:
Few facts in bengali language added.
Current number of facts translated - 12
Special Note
Indian Bengali and Bangladeshi Bengali might have some difference, I don't know Bangladeshi Bengali. Here I add Indian Bengali.
Errors
I use node version 18 and this project use node version 16. So the tests are not working for me. It would be kind if you test it in right environment first.
let me know if there is any error or test failed.