Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12 more facts translated and few fixed #324

Closed
wants to merge 0 commits into from

Conversation

dshaw0004
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #324 (3926697) into main (ad3e0aa) will increase coverage by 0.82%.
Report is 33 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
+ Coverage   90.76%   91.58%   +0.82%     
==========================================
  Files          17       20       +3     
  Lines         184      202      +18     
==========================================
+ Hits          167      185      +18     
  Misses         17       17              
Files Changed Coverage Δ
src/models/localizations/ces-cz.js 100.00% <ø> (ø)
src/models/localizations/eng-us.js 100.00% <ø> (ø)
src/models/localizations/esp-mx.js 100.00% <ø> (ø)
src/models/localizations/ger-de.js 100.00% <ø> (ø)
src/models/localizations/zho-tw.js 100.00% <ø> (ø)
src/models/localizations/ben-in.js 100.00% <100.00%> (ø)
src/models/localizations/ita-it.js 100.00% <100.00%> (ø)
src/models/localizations/kor-ko.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BeauBouchard
Copy link
Member

Thank you so much for translating more facts, we really appreciate your contribution.
Note, there is a linting issue with this from the CI/CD

101 errors and 0 warnings potentially fixable with the --fix option.

You can automatically fix linting issues with npm run test:lint:fix for most things. I think this may fix these.

@BeauBouchard BeauBouchard added the i18n translation or internationalization label Sep 22, 2023
@BeauBouchard
Copy link
Member

This also contains a lot of whitespace changes, which I would not like to merge, especially changes to package-lock and package.json

@dshaw0004
Copy link
Contributor Author

Screenshot (271)
Screenshot (272)

I can not understand what is the problem. And what is the lint and what does it do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n translation or internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants