Merge pull request #352 from wheremyfoodat/zep

Filesystem fixes
wheremyfoodat · Dec 17, 2023 · 6dc75db · 6dc75db
2 parents 03292b5 + a82c033
commit 6dc75db
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/src/core/kernel/file_operations.cpp b/src/core/kernel/file_operations.cpp
@@ -148,6 +148,11 @@ void Kernel::writeFile(u32 messagePointer, Handle fileHandle) {
 	IOFile f(file->fd);
 	auto [success, bytesWritten] = f.writeBytes(data.get(), size);
 
+	// TODO: Should this check only the byte?
+	if (writeOption) {
+		f.flush();
+	}
+
 	mem.write32(messagePointer, IPC::responseHeader(0x0803, 2, 2));
 	if (!success) {
 		Helpers::panic("Kernel::WriteFile failed");

diff --git a/src/core/kernel/kernel.cpp b/src/core/kernel/kernel.cpp
@@ -179,6 +179,30 @@ u32 Kernel::getTLSPointer() {
 // Result CloseHandle(Handle handle)
 void Kernel::svcCloseHandle() {
 	logSVC("CloseHandle(handle = %d) (Unimplemented)\n", regs[0]);
+	const Handle handle = regs[0];
+
+	KernelObject* object = getObject(handle);
+	if (object != nullptr) {
+		switch (object->type) {
+			// Close file descriptor when closing a file to prevent leaks and properly flush file contents
+			case KernelObjectType::File: {
+				FileSession* file = object->getData<FileSession>();
+				if (file->isOpen) {
+					file->isOpen = false;
+
+					if (file->fd != nullptr) {
+						fclose(file->fd);
+						file->fd = nullptr;
+					}
+				}
+				break;
+			}
+
+			default: break;
+		}
+	}
+
+	// Stub to always succeed for now
 	regs[0] = Result::Success;
 }