Add CRO support #272
Merged
Add CRO support #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: add linking, make this prettier
Pokémon XY use NULL offsets, so we can't crash upon encountering them.
Silly Pokémon X needs this.
TODO: remove debug printfs
wheremyfoodat
approved these changes
Sep 13, 2023
|
Already looked at the code, getting merged when CIs are over |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements several ldr:ro functions.
Some stuff hasn't been implemented yet (proper CRO fixing, clearing relocations upon unloading for CROs with a fix level of 0, ...) and several games are still complaining, but this should be good enough for some testing.