Fix android app data path #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SDL_GetPrefPath would fail on android for me with "Could not find JNI environment" or something similar, but this /data/data// path is the equivalent of what we want here (and I think what GetPrefPath would return anyway) |
wheremyfoodat
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also AndroidNdkModules didn't exist in my installation (may be an Archlinux NDK package thing), but its only included for a small macro android_ndk_import_module_cpufeatures, so I just replaced it with its definition, see https://android.googlesource.com/platform/external/android-cmake/+/refs/heads/upstream-master/AndroidNdkModules.cmake