Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper handling of SetApplicationCpuTimeLimit with invalid parameters #353

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Proper handling of SetApplicationCpuTimeLimit with invalid parameters #353

merged 4 commits into from
Dec 18, 2023

Conversation

noumidev
Copy link
Contributor

SetApplicationCpuTimeLimit now returns Result::OS::NotImplemented when called with invalid parameters, the CPU time limit is unaffected.
Prior to calling SetApplicationCpuTimeLimit for the first time, the CPU time limit returned by GetApplicationCpuTimeLimit is 0 on my O3DS, the changes reflect this behavior.

DEFINE_HORIZON_RESULT(InvalidCombination, 1006, InvalidArgument, Usage);
DEFINE_HORIZON_RESULT(MisalignedAddress, 1009, InvalidArgument, Usage);
DEFINE_HORIZON_RESULT(MisalignedSize, 1010, InvalidArgument, Usage);
DEFINE_HORIZON_RESULT(NotImplemented, 1012, InvalidArgument, Usage);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation 😢

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea how this happened :(

Copy link
Contributor Author

@noumidev noumidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation is fix, very skill, much prowess

@wheremyfoodat
Copy link
Owner

Much pandess

@wheremyfoodat wheremyfoodat merged commit 6c73fb1 into wheremyfoodat:master Dec 18, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants