Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up smdh getting #357

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Clean up smdh getting #357

merged 1 commit into from
Dec 27, 2023

Conversation

OFFTKP
Copy link
Collaborator

@OFFTKP OFFTKP commented Dec 27, 2023

No description provided.

@OFFTKP
Copy link
Collaborator Author

OFFTKP commented Dec 27, 2023

I need CI don't review

@wheremyfoodat
Copy link
Owner

wheremyfoodat commented Dec 27, 2023 •
edited
Loading

Code is good, emulator.hpp just needs #include <span> (IWYU)

@OFFTKP
Copy link
Collaborator Author

OFFTKP commented Dec 27, 2023

done, ready for review

@wheremyfoodat
Copy link
Owner

Needs an smdh.clear() call in ncch.cpp below the codeFile.clear() and saveData.clear() calls

@wheremyfoodat
Copy link
Owner

@OFFTKP Feel free to merge when ready

@OFFTKP OFFTKP merged commit e536f5d into wheremyfoodat:master Dec 27, 2023
14 checks passed
@wheremyfoodat
Copy link
Owner

I sort of meant after CI passed but
kanna-kamui-pat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wheremyfoodat wheremyfoodat wheremyfoodat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OFFTKP @wheremyfoodat