Partially implement ExtSaveData #447
Conversation
yretenai
force-pushed
the
ext-save-data
branch
2 times, most recently
from
badcb61 to
556b3b8
Compare
|
(The force pushes were me merging upstream, but I ended up undoing it and just using my own local primary branch.) |
src/core/services/fs.cpp
Outdated
| @@ -431,11 +432,23 @@ void FSService::deleteDirectory(u32 messagePointer) { | |||
| const u32 filePathPointer = mem.read32(messagePointer + 28); | |||
| log("FS::DeleteDirectory\n"); | |||
|
|
|||
| Helpers::warn("Stubbed FS::DeleteDirectory call!"); | |||
| Helpers::warn("Stubbed FS::DeleteDirectory call!"); // note: should we ensure the system isn't about to delete things outside of the VFS? | |||
There was a problem hiding this comment.
(This is done by isPathSafe in the archive implementations)
|
Haven't looked into it further yet but I notice a regression in Kirby Planet Robobot which went from working to panicking before booting. |
Still haven't tried newer builds, but the commit here had also broken other games like Lego Avengers. |
|
Can confirm the breakage is still present in aforementioned games + Legend of Zelda: A Link Between Worlds, Rhythm Paradise Megamix and probably more |
also actually use title id for this one.
I think Shared/SDMC is actually handled by SDMCArchive
| ExtSaveDataArchive extSaveData_sdmc; | ||
| ExtSaveDataArchive sharedExtSaveData_nand; | ||
| std::unordered_map<u64, ExtSaveDataArchive> extSaveData_sdmc; | ||
| std::unordered_map<u64, ExtSaveDataArchive> nandExtSaveData_nand; | ||
| SystemSaveDataArchive systemSaveData; |
There was a problem hiding this comment.
These are also not correctly reset
Refactors SDMC ExtData layout to reflect VSXE behavior and properly stores FormatInfo.
Created DeleteDirectory and DeleteDirectoryRecursively stubs for future use.
Things that are still a ?: