Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Metal #527

Closed
wants to merge 94 commits into from
Closed

WIP: Metal #527

wants to merge 94 commits into from

Conversation

SamoZ256
Copy link
Contributor

@SamoZ256 SamoZ256 commented Jul 2, 2024

This is a work in progress Metal backend. TODOs:

  • Viewport and scissor
  • Regions when doing display transfer and texture copy
  • Correct clipping
  • Color mask
  • Stencil ref
  • Blend color
  • Clear render targets after creation

@wheremyfoodat wheremyfoodat changed the base branch from master to metal July 2, 2024 15:42
@wheremyfoodat
Copy link
Owner

wheremyfoodat commented Jul 2, 2024

Hi!

I am not sure how feasible it is to upstream and maintain a Metal renderer on upstream at the moment, so I redirected the PR to a dedicated Metal branch instead of the upstream master branch for the time being.

Some notes:

  • Please move metal-cpp into a submodule instead of including it in the repo, since that makes it a lot easier to update if needed and to search through the repo without getting hits on metal-cpp stuff
  • Switch and replace of Handle -> HandleType has caused quite the mess in the core code. This is generally not a wanted change, both because random bits of text got changed and because Handle and similar names are used in all 3DS documentation/libraries/RE.
  • If possible, please undo random older files being formatted/changed unnecessarily (eg all the service/kernel/memory files), those will be formatted eventually but doing it en masse and in unrelated PRs leads to the PR being impossible to review
    image

@wheremyfoodat
Copy link
Owner

wheremyfoodat commented Jul 2, 2024

Nice work on the renderer of course, nice to see that particular scene running nicely on it.

Changing the PR to be a draft so it's not accidentally merged while it's not ready, feel free to change it back when you feel like it.

@wheremyfoodat wheremyfoodat marked this pull request as draft July 2, 2024 16:01
@wheremyfoodat wheremyfoodat changed the base branch from metal to metal2 July 23, 2024 08:43
@wheremyfoodat
Copy link
Owner

wheremyfoodat commented Jul 23, 2024

Updated base branch to reflect the new renderer code upstream has, PR still merges gracefully thankfully.

@SamoZ256 SamoZ256 closed this Aug 16, 2024
@SamoZ256 SamoZ256 mentioned this pull request Aug 16, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants