Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt UI: fix menu bar on MacOS #668

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

twvd
Copy link
Contributor

@twvd twvd commented Dec 6, 2024

MacOS requires a 'global' menubar to be available (e.g. QtMenuBar(nullptr)).

Please test if this doesn't break anything on Windows/Linux..

image

MacOS requires a 'global' menubar to be available (e.g. QtMenuBar(nullptr)).
@wheremyfoodat
Copy link
Owner

Lgtm, testing locally on Windows in a sec
(Also apparently this is also needed on some Linux distros)

@wheremyfoodat
Copy link
Owner

Update: Works fine here

@wheremyfoodat wheremyfoodat enabled auto-merge (squash) December 6, 2024 17:35
@wheremyfoodat wheremyfoodat merged commit 1d2429c into wheremyfoodat:master Dec 6, 2024
14 checks passed
@twvd twvd deleted the macmenu branch December 6, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants