Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building crypto++ for x64 target on Apple silicon MacOS #683

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fix building crypto++ for x64 target on Apple silicon MacOS #683

merged 1 commit into from
Dec 10, 2024

Conversation

twvd
Copy link
Contributor

@twvd twvd commented Dec 10, 2024

I think this will let you use the M1 Github runners, try it..

@wheremyfoodat
Copy link
Owner

Won't this break if you're on Apple and CMAKE_OSX_ARCHITECTURES is not defined?

@twvd
Copy link
Contributor Author

twvd commented Dec 10, 2024

True.. Fixed that

@wheremyfoodat
Copy link
Owner

What if I'm on Windows but I'm a lunatic that defines CMAKE_OSX_ARCHITECTURES /s

@wheremyfoodat wheremyfoodat merged commit 4e2c825 into wheremyfoodat:master Dec 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wheremyfoodat wheremyfoodat wheremyfoodat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twvd @wheremyfoodat