Bug fix in allocation memory for non-multiple of 8 sizes #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix bug in size allocation for non-multiples of 8.
b->data = calloc((size + 7) / 8, 1);
and then in the
bloom_read
functionb->data = (char *)malloc((m + 7) / 8);
To avoid issues with older version, I've changed
FILE_VERSION
to 2uand then handle different versions with if statements when reading saved bloom filters at the end.
Hard to test whether this change will affect older versions, but this version handling approach
will work as a safeguard without having issues with bloom filters saved before this change.