Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing resolveUsing, displayUsing and fillUsing #235

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jeffreyzant
Copy link

Also mentioned in #224, see the updated docs for the usage. If there are any questions or wanted improvements feel free to let me know!

Copy link
Member

@voidgraphics voidgraphics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for the PR. I would love @Nyratas to take a look at it before we approve it - but in the meantime, I have highlighted some quick fixes that would be needed if we were to merge it.

README.md Outdated Show resolved Hide resolved
src/Flexible.php Outdated Show resolved Hide resolved
src/Flexible.php Outdated Show resolved Hide resolved
@jeffreyzant
Copy link
Author

I've got it fixed, let me know if there's anything else!

@hasnat-we
Copy link

@Nyratas Thanks for this awesome library. Can you please implement the optional callback resolver? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants