Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Move elements to the top / bottom #459

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Feature: Move elements to the top / bottom #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ae7adcd
chore: Added events for moving elements to the top and bottom
mmi-cyrano Jun 2, 2023
50805db
chore: Build production build
mmi-cyrano Jun 2, 2023
4712c25
fix: Fixed wrong icons for action.
mmi-cyrano Jun 2, 2023
26eceaa
fix: Moving element to last in array
mmi-cyrano Jun 2, 2023
5917e7a
fix
mmi-cyrano Jun 2, 2023
c02f82b
fix: First element couldnt be moved to the last element.
mmi-cyrano Jun 2, 2023
4ccb929
chore: Removed console.log
mmi-cyrano Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/js/field.js
View file
Open in desktop

Large diffs are not rendered by default.

24 changes: 24 additions & 0 deletions resources/js/components/FormField.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
:mode="mode"
@move-up="moveUp(group.key)"
@move-down="moveDown(group.key)"
@move-to-bottom="moveToBottom(group.key)"
@move-to-top="moveToTop(group.key)"
@remove="remove(group.key)"
/>
</div>
Expand Down Expand Up @@ -221,6 +223,28 @@ export default {
this.order.push(group.key);
},

/**
* Move a group to the bottom
*/
moveToBottom(key) {
let index = this.order.indexOf(key);

if (index < 0 || index >= this.order.length - 1) return;

this.order.push(this.order.splice(index, 1)[0]);
},

/**
* Move a group to the top
*/
moveToTop(key) {
let index = this.order.indexOf(key);

if (index <= 0) return;

this.order.unshift(this.order.splice(index, 1)[0]);
},

/**
* Move a group up
*/
Expand Down
30 changes: 30 additions & 0 deletions resources/js/components/FormGroup.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,22 @@
>
<icon type="selector" class="align-top" width="16" height="16" />
</button>
<button
dusk="move-to-top-group"
type="button"
class="group-control btn border-l border-gray-200 dark:border-gray-700 w-8 h-8 block"
:title="__('Move to top')"
@click.prevent="moveToTop">
<icon type="chevron-double-up" class="align-top" width="16" height="16" />
</button>
<button
dusk="move-to-bottom-group"
type="button"
class="group-control btn border-l border-gray-200 dark:border-gray-700 w-8 h-8 block"
:title="__('Move to bottom')"
@click.prevent="moveToBottom">
<icon type="chevron-double-down" class="align-top" width="16" height="16" />
</button>
<button
dusk="move-up-group"
type="button"
Expand Down Expand Up @@ -143,6 +159,20 @@ export default {
},

methods: {
/**
* Move this group to the top
*/
moveToTop() {
this.$emit("move-to-top");
},

/**
* Move this group to the bottom
*/
moveToBottom() {
this.$emit("move-to-bottom");
},

/**
* Move this group up
*/
Expand Down