Make sure to open files in binary mode, in order to correctly transfe…

…r files on Windows. (lnussbaum/pull/19)
whitehat101 · Oct 17, 2013 · 743eea2 · 743eea2
1 parent 291835d
commit 743eea2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/data/doc/xmpp4r/examples/advanced/recvfile.rb b/data/doc/xmpp4r/examples/advanced/recvfile.rb
@@ -58,7 +58,7 @@
       puts "Waiting for stream configuration"
       if stream.accept
         puts "Stream established"
-        outfile = File.new(filename, (offset ? 'a' : 'w'))
+        outfile = File.new(filename, (offset ? 'ab' : 'wb'))
         while buf = stream.read(65536)
           outfile.write(buf)
           print '.'

diff --git a/lib/xmpp4r/bytestreams/helper/filetransfer.rb b/lib/xmpp4r/bytestreams/helper/filetransfer.rb
@@ -70,7 +70,7 @@ class FileSource
       include TransferSource
 
       def initialize(filename)
-        @file = File.new(filename)
+        @file = File.new(filename, "rb")
         @filename = filename
         @bytes_read = 0
         @length = nil