Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regex url metric #279

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Add regex url metric #279

merged 1 commit into from
Mar 26, 2024

Conversation

naddeoa
Copy link
Collaborator

@naddeoa naddeoa commented Mar 26, 2024

After doing manual tests, I noticed that the url detection from presidio does very poorly when code is involved. It has false positives on things like string.split(). The regex performs much better for less compute for urls.

After doing manual tests, I noticed that the url detection from presidio
does very poorly when code is involved. It has false positives on things
like string.split(). The regex performs much better for less compute for
urls.
@naddeoa naddeoa merged commit 7f84f59 into workflow Mar 26, 2024
5 checks passed
@naddeoa naddeoa deleted the regex-url branch March 26, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant