Update/partial rewrite of editable-grid #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
approved these changes
Oct 26, 2023
| <dependency> | ||
| <groupId>org.slf4j</groupId> | ||
| <artifactId>slf4j-simple</artifactId> | ||
| <version>${slf4j.version}</version> |
solomax
requested changes
Oct 27, 2023
...le-grid-parent/editable-grid-examples/src/main/java/org/wicketstuff/egrid/page/HomePage.html
Outdated
Show resolved
Hide resolved
solomax
approved these changes
Oct 27, 2023
|
Thanks for the contribution @silasporth ! |
|
Hi @silasporth I am trying to understand how to update my code from 10.0.0-M1 to 10.0.0 (see #849) but having some issues: is there any usage sample around? |
Hi, currently there is only the example in editable-grid-parent/editable-grid-examples but it should be working and it shows a minimal example. |
|
Thank you @silasporth I was able to get around it: apache/syncope@f00ad78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a project, I came across the editable-grid and wanted to use it. But I found some bugs that I couldn't fix unless I ported the whole structure to my project. Well, I did that because I liked the idea of the base so much and then I decided to fix the bugs here as well.
What I did:
If there are problems with any of these changes, I'm happy to help.