Adding time picker component #654
Open
+346
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iisakkirotko
requested changes
May 21, 2024
There was a problem hiding this comment.
Hey @mikegiann01!
Great to see another PR from you. I had a couple of comments:
- Could you include some tests for the component? You can take a look at https://github.com/widgetti/solara/blob/master/tests/unit/input_date_test.py for some guidance
- I wonder if we should add an argument for using seconds in the picker? Do you think without it we already cover 99% of use cases, or that it would see some use? @maartenbreddels and @mariobuikhuizen feel free to weigh in as well.
- I think we should also expose some of the restrictions on allowed inputs from Vuetify. At least
allowed_minutesI could see people using, when they only want to allow picking in 15/30 minute intervals.
|
should i create a new PR the tests? |
|
No need, preferably add the tests to this PR. |
iisakkirotko
requested changes
May 31, 2024
Comment on lines
+150
to
+166
| def test_input_time_on_open_value(): | ||
| on_open_value = MagicMock() | ||
| on_value = MagicMock() | ||
| el = InputTime(value=now, label="label", on_value=on_value, on_open_value=on_open_value) | ||
| box, rc = solara.render(el, handle_error=False) | ||
| menu = rc.find(vw.Menu) | ||
| assert menu is not None | ||
|
|
||
| # Simulate opening the time picker | ||
| menu.widget.v_model = True | ||
| assert on_open_value.call_count == 1 | ||
| assert on_open_value.call_args[0][0] is True | ||
|
|
||
| # Simulate closing the time picker | ||
| menu.widget.v_model = False | ||
| assert on_open_value.call_count == 2 | ||
| assert on_open_value.call_args[0][0] is False |
There was a problem hiding this comment.
Should this be tested by clicking on the input element, rather than by directly opening the menu?
maartenbreddels
force-pushed
the
master
branch
2 times, most recently
from
86646f5 to
df2fd66
Compare
Co-authored-by: Iisakki Rotko <[email protected]>
Co-authored-by: Iisakki Rotko <[email protected]>
maartenbreddels
force-pushed
the
feature_branch
branch
from
3f572ec to
0205805
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!Created a time picker component, working also on input_timerange component