fix: a failing websocket.send would drop the connection silently #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of assuming all exceptions are due to a closed connection, we only ignored the exception when it is due to a closed connection. This caused issues in #841 where we called from the same thread as the websocket's portal, which caused the connection to be ignored without any error message.
maartenbreddels
temporarily deployed
to
fix_silent_error_on_websocket_send_fail - solara-stable PR #919
Render
Destroyed
iisakkirotko
approved these changes
Dec 12, 2024
Comment on lines
+129
to
+138
| async def _send_bytes_exc(self, data: bytes): | ||
| # make sures we catch the starlette/websockets specific exception | ||
| # and re-raise it as a websocket.WebSocketDisconnect | ||
| try: | ||
| await self.ws.send_bytes(data) | ||
| except websockets.exceptions.ConnectionClosed as e: | ||
| raise websocket.WebSocketDisconnect() from e | ||
| except RuntimeError as e: | ||
| # starlette throws a RuntimeError once you call send after the connection is closed | ||
| raise websocket.WebSocketDisconnect() from e |
There was a problem hiding this comment.
Should this be implemented as a decorator / context manager to not define two almost identical functions?
There was a problem hiding this comment.
As discussed in private, it's DRY (don't repeat yourself) vs YAGNI (you ain't gonna need it). It would make it more difficult to read, vs it makes it more difficult to maintain.
In this particular case, we probably should have overwritten the send(..) method and should have pushed the branching down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of assuming all exceptions are due to a closed connection, we only ignored the exception when it is due to a closed connection.
This caused issues in #841 where we called from the same thread as the websocket's portal, which caused the connection to be ignored without any error message.