Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: we did not test against vue 3.x #921

Merged
merged 1 commit into from
Dec 12, 2024
Merged

ci: we did not test against vue 3.x #921

merged 1 commit into from
Dec 12, 2024

Conversation

maartenbreddels
Copy link
Contributor

Fixes #920

@maartenbreddels maartenbreddels temporarily deployed to ci_fix_test_against_vue3 - solara-stable PR #921 December 12, 2024 14:33 — with Render Destroyed
@maartenbreddels maartenbreddels mentioned this pull request Dec 12, 2024
Open
2 tasks
@maartenbreddels maartenbreddels force-pushed the ci_fix_test_against_vue3 branch from 9f7254c to 529ab98 Compare December 12, 2024 14:37
@maartenbreddels maartenbreddels temporarily deployed to ci_fix_test_against_vue3 - solara-stable PR #921 December 12, 2024 14:37 — with Render Destroyed
iisakkirotko
iisakkirotko approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@iisakkirotko iisakkirotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Also nice to see we didn't break support in the meantime.

On a separate note: we should probably migrate the testing suite over to uv at some point.

@maartenbreddels
Copy link
Contributor Author

Also nice to see we didn't break support in the meantime.

Yeah 😅

@maartenbreddels maartenbreddels merged commit 1aa9928 into master Dec 12, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iisakkirotko iisakkirotko iisakkirotko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: not testing vue3
2 participants
@maartenbreddels @iisakkirotko