[WFCORE-6519] Enabling logging tests because they no longer fail neither on JDK17 not on JDK21 #5677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her on JDK17 not on JDK21
github-actions
bot
added
the
deps-ok
yersan
approved these changes
Sep 25, 2023
|
I've approved this since the change is pretty clear: it just removed the condition to skip the test under JDK12. However, I've noticed the surefire plugin is configured to include only tests with the TestCase suffix, so I'm going to file a new Jira to rename this test, so far I don't see any condition that requires it and it looks like it was unintentional. |
yersan
added
the
ready-for-merge
|
Thanks @ropalka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFCORE-6519