Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-6527]: Upgrade JGit from 6.6.0.202305301015-r to 6.7.0.202309050840-r #5688

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

ehsavoie
Copy link
Contributor

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Sep 26, 2023
@yersan yersan added the 23.x label Sep 27, 2023
pom.xml Outdated
Comment on lines 704 to 708
<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
<version>${version.commons-codec}</version>
</dependency>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehsavoie Have you tested whether it is just possible to exclude commons-codec transitive dependency from org.eclipse.jgit? It seems it is not used at runtime (it has not been declared for org.eclipse.jgit module.xml) and we do not compile org.eclipse.jgit, so I guess excluding it would be enough.

@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Oct 10, 2023
@yersan yersan merged commit a657132 into wildfly:main Oct 11, 2023
1 check passed
@yersan
Copy link
Collaborator

yersan commented Oct 11, 2023

Thanks @ehsavoie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants