Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-6542]: Upgrade the Windows service tools. #5700

Merged
merged 1 commit into from
Oct 12, 2023
Merged

[WFCORE-6542]: Upgrade the Windows service tools. #5700

merged 1 commit into from
Oct 12, 2023

Conversation

ehsavoie
Copy link
Contributor

@ehsavoie ehsavoie commented Oct 4, 2023

  • Adding explicit dependency on commons-daemon artefact
  • Removing old binaries
  • Using the maven dependency plugin to extract and rename the binaries
  • Updating the assembly.xml to have them at their proper place in the docs folder

Issue: https://issues.redhat.com/browse/WFCORE-6542

@github-actions github-actions bot added the deps-changed Dependencies have been checked, and there are changes highlighted in a comment label Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Dependency Tree Analyzer Output:

New Dependencies:

  • commons-daemon:commons-daemon:zip:bin-windows:1.3.4:compile

CC @wildfly/prod

@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 12961 outcome was UNKNOWN using a merge of 41aa32c
Summary: Canceled (Error while applying patch; cannot find commit e363572 in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/5700/merge branch was updated and the commit selected for the ... Build time: 00:00:36

@wildfly-ci
Copy link

Core -> Full Integration Build 12882 outcome was UNKNOWN using a merge of 41aa32c
Summary: Canceled (Error while applying patch; cannot find commit e363572 in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/5700/merge branch was updated and the commit selected for the ... Build time: 00:00:19

@wildfly-ci
Copy link

Core -> Full Integration Build 13105 outcome was UNKNOWN using a merge of 41aa32c
Summary: Canceled (Error while applying patch; cannot find commit e363572 in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/5700/merge branch was updated and the commit selected for the ... Build time: 00:00:18

@wildfly-ci

This comment was marked as outdated.

Sign in to view
@wildfly-ci

This comment was marked as outdated.

Sign in to view
@ehsavoie
[WFCORE-6542]: Upgrade the Windows service tools.
07fa607 
 * Adding explicit dependency on commons-daemon artefact
 * Removing old binaries
 * Using the maven dependency plugin to extract and rename the binaries
 * Updating the assembly.xml to have them at their proper place in the
   docs folder

Issue: https://issues.redhat.com/browse/WFCORE-6542

Signed-off-by: Emmanuel Hugonnet <[email protected]>
@wildfly-ci

This comment was marked as outdated.

Sign in to view
@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Oct 12, 2023
@yersan
Copy link
Collaborator

yersan commented Oct 12, 2023

This change passed the eap-8.x-scripts-service-windows tests under QE testsuite

@yersan yersan merged commit 0fe2660 into wildfly:main Oct 12, 2023
1 check passed
@yersan
Copy link
Collaborator

yersan commented Oct 12, 2023

Thanks @ehsavoie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yersan yersan yersan approved these changes

Assignees
No one assigned
Labels
deps-changed Dependencies have been checked, and there are changes highlighted in a comment ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ehsavoie @wildfly-ci @yersan @bstansberry