[WFCORE-6679]: ManagementReadXmlTestCase inputs are too fragile. #5851
Conversation
github-actions
bot
added
the
deps-ok
...ite/domain/src/test/java/org/jboss/as/test/integration/domain/ManagementReadXmlTestCase.java
Outdated
Show resolved
Hide resolved
|
Hi @ehsavoie , sadly this got a conflict because |
|
@yersan done |
This comment was marked as off-topic.
This comment was marked as off-topic.
...ain/src/test/java/org/jboss/as/test/integration/domain/suites/ManagementReadXmlTestCase.java
Show resolved
Hide resolved
...ain/src/test/java/org/jboss/as/test/integration/domain/suites/ManagementReadXmlTestCase.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,71 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
I think this could be removed and used as a base for the domain-configs/domain-standard.xml which is indeed the base configuration used to start the domain for DomainTestSupport
There was a problem hiding this comment.
I don't understand
There was a problem hiding this comment.
This test is about checking the runtime configuration of a managed server thus this base XML file is here to help produce the expected runtime configuration of those managed servers.
There was a problem hiding this comment.
@ehsavoie Sorry for the delay providing feedback about this. My comment here does not make sense, as you stated before, although this is a domain mode test, we are interested in getting the managed server configuration and I pointed you out to our domain standard config
ehsavoie
force-pushed
the
WFCORE-6679
branch
from
960beb6 to
38cf0f4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@ehsavoie ManagementReadXmlTestCase has failed repeatedly in Windows, could you take a look? |
ehsavoie
force-pushed
the
WFCORE-6679
branch
from
38cf0f4 to
d0be376
Compare
* Generating the servers configuration through scripts to make them less fragile. Jira: https://issues.redhat.com/browse/WFCORE-6679 Signed-off-by: Emmanuel Hugonnet <[email protected]>
ehsavoie
force-pushed
the
WFCORE-6679
branch
from
d0be376 to
2f5d7e9
Compare
|
Core -> Full Integration Build 13526 outcome was UNKNOWN using a merge of 2f5d7e9 |
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Emmanuel Hugonnet <[email protected]>
Signed-off-by: Emmanuel Hugonnet <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
yersan
added
the
ready-for-merge
|
Thanks @ehsavoie |
Jira: https://issues.redhat.com/browse/WFCORE-6679