[WFCORE-6503]:Add support for unmanaged deployments with YAML extension. #5860

ehsavoie · 2024-02-14T13:57:00Z

checking that the YAML deployment is unmanaged.
adding the unmanaged deployment to the list of operations
adding some light esting on this

Jira: https://issues.redhat.com/browse/WFCORE-6503
https://issues.redhat.com/browse/WFLY-19442
Proposal: wildfly/wildfly-proposals#554
Documenation PR: wildfly/wildfly#17970

mnovak1 · 2024-02-29T08:50:48Z

For WARN message it seems to be logging some null values. For example:

 is ignored
09:46:09,663 WARN  [org.jboss.as.controller.management-operation] (main) WFLYCTL0506: The yaml element org.jboss.as.failure: {module: org.jboss.as.failure}
 is ignored
09:46:09,664 WARN  [org.jboss.as.controller.management-operation] (main) WFLYCTL0506: The yaml element null
 is ignored

for yaml:

wildfly-configuration:
    extension:
      org.jboss.as.failure:
        module: org.jboss.as.failure
    socket-binding-group:
        standard-sockets:
          default-interface: public
          port-offset: ${jboss.socket.binding.port-offset:0}
          socket-binding:
              http:
                interface: public
              https:
          remote-destination-outbound-socket-binding:
            mail-snmt:  
              host: foo
              port: 8081
            foo2:
              host: foo2
              port: 8082

I should log the name of yaml tag which is ignored.

controller/src/main/java/org/jboss/as/controller/logging/ControllerLogger.java

yersan · 2024-03-19T10:04:56Z

Hello @bstansberry, you added "Feature" and "missing-reqs" labels to this PR. So far we are treating this as an enhancement, do you want this to be treated as a Feature Request instead? There is more information about this on the Jira.

yersan

Added some comments to think about whether some stuff that could be moved to simply a bit the changes on the reload handlers and ModelControllerImpl, they can be evolved later, but it took me some time to figure out why we needed them.

In general, it looks pretty isolated to yaml work, so, except the additional trailing white space on the --yaml option, looks good and I think we can go with them. However, if possible, we should move the conditions added on reload handlers and ModelControllerImpl to the ConfigurationExtension.shouldProcessOperations.

controller/src/main/java/org/jboss/as/controller/persistence/ConfigurationPersister.java

testsuite/test-runner/src/main/java/org/wildfly/core/testrunner/Server.java

...test/manualmode/management/persistence/yaml/test-remove-attribute-removes-above-resource.yml

...oller/src/main/java/org/jboss/as/controller/persistence/yaml/YamlConfigurationExtension.java

controller/src/main/java/org/jboss/as/controller/ModelControllerImpl.java

controller/src/main/java/org/jboss/as/controller/RunningModeControl.java

ehsavoie · 2024-04-05T07:21:00Z

@bstansberry @yersan I've rebased on #5934 so only the feature part where unmanaged deployments are supported is here now.

yersan · 2024-04-05T08:14:52Z

@bstansberry I removed the feature label due to the https://issues.redhat.com/browse/WFCORE-6503 comments. That probably was a mistake since you added them after the Jira discussions.

Just to be clear, do you want to treat this as a pure feature request instead of an enhancement that adds more value to a released feature request?

yersan · 2024-04-26T09:42:34Z

/retest

bstansberry · 2024-06-25T18:39:49Z

...oller/src/main/java/org/jboss/as/controller/persistence/yaml/YamlConfigurationExtension.java

+        OperationEntry operationEntry = rootRegistration.getOperationEntry(PathAddress.pathAddress("deployment", name), ADD);
+        if (deployment.getValue() != null && deployment.getValue() instanceof Map) {
+            Map<String, Object> attributes = (Map<String, Object>) deployment.getValue();
+            Map<String, Object> content = (Map<String, Object>) (((Iterable<? extends Object>) attributes.get("content")).iterator().next());


This can NPE if there is no 'content' and fail in other confusing ways if it's not a list or an empty list.

Fixing that as it is only for validation purpose

...oller/src/main/java/org/jboss/as/controller/persistence/yaml/YamlConfigurationExtension.java

bstansberry · 2024-06-25T19:12:58Z

server/src/main/java/org/jboss/as/server/ServerEnvironment.java

-            Path[] supplementalConfigurationFiles = findSupplementalConfigurationFiles(null, supplementalConfiguration);
-            ConfigurationExtension configurationExtension = ConfigurationExtensionFactory.createConfigurationExtension(supplementalConfigurationFiles);
-            if (configurationExtension != null) {
-                configInteractionPolicy = configurationExtension.shouldProcessOperations(runningModeControl) ? ConfigurationFile.InteractionPolicy.READ_ONLY : configInteractionPolicy;


Note to reviewers:

The configInteractionPolicy var is never read in this branch, making the assignment here pointless and thus the other removed lines pointless as well.

There are uses of the var in other branches.

bstansberry · 2024-06-25T19:22:23Z

@yersan Sorry for not answering your questions until now. This is new user controllable behavior so it's a feature. We should communicate that to WF users by using Feature Request issue type. It's been validated as part of validating the earlier YAML work, so once code review stuff comments here are addressed by @ehsavoie this can be merged.

…ion. * checking that the YAML deployment is unmanaged. * adding the unmanaged deployment to the list of operations * adding some light testing on this * fixing issue WFCORE-6857 where you couldn't enable an unmanaged deployment with yaml Jira: https://issues.redhat.com/browse/WFCORE-6503 https://issues.redhat.com/browse/WFCORE-6857 Proposal: wildfly/wildfly-proposals#554 Signed-off-by: Emmanuel Hugonnet <[email protected]>

bstansberry

@yersan This LGTM.

yersan

Thanks for helping with the review @bstansberry .
The points I reviewed were finally moved to a different issue and were already merged. I've checked it again and I have no more questions.

There is still pending paperwork on the RFE Jira that I guess, still prevents merging this.

yersan · 2024-06-28T10:11:30Z

RFE pending paperwork was resolved, so merging this

yersan · 2024-06-28T10:11:57Z

Thanks @ehsavoie @mnovak1 @bstansberry

ehsavoie marked this pull request as ready for review February 14, 2024 13:57

github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Feb 14, 2024

This comment was marked as outdated.

Sign in to view

ehsavoie force-pushed the WFCORE-6503 branch from 826b453 to 18a3f13 Compare February 28, 2024 16:55

ehsavoie force-pushed the WFCORE-6503 branch 2 times, most recently from d00ce87 to 3d5976c Compare March 1, 2024 10:44

mnovak1 reviewed Mar 1, 2024

View reviewed changes

controller/src/main/java/org/jboss/as/controller/logging/ControllerLogger.java Outdated Show resolved Hide resolved

ehsavoie force-pushed the WFCORE-6503 branch 2 times, most recently from cf04996 to fd8e69e Compare March 1, 2024 16:01

ehsavoie force-pushed the WFCORE-6503 branch 6 times, most recently from c6dcfa8 to b3b2923 Compare March 13, 2024 13:03

This comment was marked as outdated.

Sign in to view

ehsavoie force-pushed the WFCORE-6503 branch from b3b2923 to 12f2de6 Compare March 13, 2024 13:47

yersan reviewed Mar 18, 2024

View reviewed changes

controller/src/main/java/org/jboss/as/controller/logging/ControllerLogger.java Outdated Show resolved Hide resolved

bstansberry added Feature This PR adds a new feature to WildFly missing-reqs This PR is missing external requirements before it can be merged labels Mar 18, 2024

ehsavoie force-pushed the WFCORE-6503 branch from 12f2de6 to ea55b5c Compare March 19, 2024 08:34

This comment was marked as outdated.

Sign in to view

ehsavoie force-pushed the WFCORE-6503 branch from 34bacd1 to ed19e2f Compare March 20, 2024 17:54

ehsavoie force-pushed the WFCORE-6503 branch from fac75cb to 04fa197 Compare March 29, 2024 14:53

This comment was marked as outdated.

Sign in to view

ehsavoie force-pushed the WFCORE-6503 branch from 04fa197 to d6e48e3 Compare April 2, 2024 09:05

yersan removed the Feature This PR adds a new feature to WildFly label Apr 3, 2024

yersan removed the missing-reqs This PR is missing external requirements before it can be merged label Apr 3, 2024

yersan reviewed Apr 4, 2024

View reviewed changes

ehsavoie force-pushed the WFCORE-6503 branch from d6e48e3 to 6e63f71 Compare April 5, 2024 07:18

ehsavoie force-pushed the WFCORE-6503 branch from 6e63f71 to d1d9329 Compare April 5, 2024 09:32

This comment was marked as outdated.

Sign in to view

ehsavoie force-pushed the WFCORE-6503 branch from d1d9329 to 93c017f Compare April 8, 2024 08:20

ehsavoie force-pushed the WFCORE-6503 branch from 93c017f to 8d3b0bc Compare April 26, 2024 12:44

ehsavoie force-pushed the WFCORE-6503 branch from 8d3b0bc to e13c1e8 Compare June 4, 2024 13:21

yersan added Feature This PR adds a new feature to WildFly missing-reqs This PR is missing external requirements before it can be merged labels Jun 4, 2024

This comment was marked as outdated.

Sign in to view

ehsavoie force-pushed the WFCORE-6503 branch from e13c1e8 to ee81c4f Compare June 10, 2024 15:02

ehsavoie force-pushed the WFCORE-6503 branch from ee81c4f to 187a9cf Compare June 18, 2024 14:39

yersan removed the missing-reqs This PR is missing external requirements before it can be merged label Jun 25, 2024

bstansberry requested changes Jun 25, 2024

View reviewed changes

ehsavoie force-pushed the WFCORE-6503 branch from 187a9cf to b7b8cac Compare June 26, 2024 09:25

This comment was marked as off-topic.

Sign in to view

bstansberry added the 25.x label Jun 26, 2024

bstansberry approved these changes Jun 26, 2024

View reviewed changes

yersan approved these changes Jun 27, 2024

View reviewed changes

yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Jun 28, 2024

yersan merged commit c9aa242 into wildfly:main Jun 28, 2024
10 of 12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WFCORE-6503]:Add support for unmanaged deployments with YAML extension. #5860

[WFCORE-6503]:Add support for unmanaged deployments with YAML extension. #5860

ehsavoie commented Feb 14, 2024 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

mnovak1 commented Feb 29, 2024

This comment was marked as outdated.

yersan commented Mar 19, 2024

This comment was marked as outdated.

This comment was marked as outdated.

yersan left a comment

ehsavoie commented Apr 5, 2024

yersan commented Apr 5, 2024

This comment was marked as outdated.

This comment was marked as outdated.

yersan commented Apr 26, 2024

This comment was marked as outdated.

bstansberry Jun 25, 2024

ehsavoie Jun 26, 2024

bstansberry Jun 25, 2024

bstansberry commented Jun 25, 2024

This comment was marked as off-topic.

bstansberry left a comment

yersan left a comment

yersan commented Jun 28, 2024

yersan commented Jun 28, 2024

[WFCORE-6503]:Add support for unmanaged deployments with YAML extension. #5860

[WFCORE-6503]:Add support for unmanaged deployments with YAML extension. #5860

Conversation

ehsavoie commented Feb 14, 2024 • edited Loading

This comment was marked as outdated.

This comment was marked as outdated.

mnovak1 commented Feb 29, 2024

This comment was marked as outdated.

yersan commented Mar 19, 2024

This comment was marked as outdated.

This comment was marked as outdated.

yersan left a comment

Choose a reason for hiding this comment

ehsavoie commented Apr 5, 2024

yersan commented Apr 5, 2024

This comment was marked as outdated.

This comment was marked as outdated.

yersan commented Apr 26, 2024

This comment was marked as outdated.

bstansberry Jun 25, 2024

Choose a reason for hiding this comment

ehsavoie Jun 26, 2024

Choose a reason for hiding this comment

bstansberry Jun 25, 2024

Choose a reason for hiding this comment

bstansberry commented Jun 25, 2024

This comment was marked as off-topic.

bstansberry left a comment

Choose a reason for hiding this comment

yersan left a comment

Choose a reason for hiding this comment

yersan commented Jun 28, 2024

yersan commented Jun 28, 2024

ehsavoie commented Feb 14, 2024 •

edited

Loading