[WFCORE-7091] Create the ModelTestModelControllerService variants for the WF 31 controllers #6280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
… it is preparing the legacy controllers Jira issue: https://issues.redhat.com/browse/WFCORE-7091
yersan
changed the title
kabir
reviewed
Dec 16, 2024
| ModelInitializer modelInitializer = null; | ||
| if (modelInitializerEntries != null && !modelInitializerEntries.isEmpty()) { | ||
| modelInitializer = new LegacyModelInitializer(modelInitializerEntries); | ||
| } |
There was a problem hiding this comment.
This code seems to duplicate a lot of the code from the previous method. Can they be unified more?
| convertedBootOps, | ||
| convertedValidationFilter, | ||
| convertedLegacyModelVersion, | ||
| convertedModelInitializerEntries); |
There was a problem hiding this comment.
Can this be unified, e.g. so we just pass in null for the stabilty? If so you can get rid of this whole if/else block
| convertedValidateOpsFilter, | ||
| convertedBootOps, | ||
| convertedModelVersion, | ||
| persistXml); |
There was a problem hiding this comment.
Can this be unified, e.g. so we just pass in null for the stabilty? If so you can get rid of this whole if/else block
There was a problem hiding this comment.
I'll check with the latest changes I added in the wildfly-test-legacy where we are explicitely adding the Stability level, I guess it should be possible since now it will be visible to the child classloader, but I have to double check it.
There was a problem hiding this comment.
Although, in any case, it won't be possible until we bump wildfly-test-legacy to 9.0.0 in WidlFly Core, so, for the first cut I will leave it as it is. If we do it now, it will break the current tests since Stability is not visible for the legacy controllers yet
|
Core -> Full Integration Build 14430 outcome was UNKNOWN using a merge of abea9d2 |
|
Core -> Full Integration Build 14129 outcome was UNKNOWN using a merge of abea9d2 |
|
Core -> WildFly Preview Integration Build 14211 outcome was UNKNOWN using a merge of abea9d2 |
|
Thanks @kabir We can simplify those two invocations later once all gets merged |
|
Core -> WildFly Preview Integration Build 14212 outcome was FAILURE using a merge of abea9d2 Failed tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue: https://issues.redhat.com/browse/WFCORE-7091
@kabir / @pferraro This is preliminary work to prepare WildFly Core for the usage of the incoming WildFly Legacy Test release. Basically:
Once this PR gets approved, we will release a WildFly Core version, we will upgrade wildfly legacy tests with that released WildFly core version, and we will later bump it in WIldFly Core. We can avoid this intermediate step, if we release wildfly legacy tests compiled with a WildlFly Core snapshot version, but I am more in favor of using a released one.