Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-7095] Deprecate ModuleDependency.getIdentifier() for removal; move partly away from MI in ServiceModuleLoader #6282

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WFCORE-7095] Deprecate ModuleDependency.getIdentifier() for removal; move partly away from MI in ServiceModuleLoader #6282

wants to merge 2 commits into from
+166 −97

Conversation

bstansberry
Copy link
Contributor

@bstansberry bstansberry changed the title [WFCORE-7095] Deprecate ModuleDependency.getIdentifier() for removal; move partly away from MI in ServiceModuleLoaderWfcore 7095 [WFCORE-7095] Deprecate ModuleDependency.getIdentifier() for removal; move partly away from MI in ServiceModuleLoader Dec 15, 2024
@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 14206 outcome was FAILURE using a merge of cb44203
Summary: Tests failed: 2 (2 new), passed: 5257, ignored: 84 Build time: 03:42:51

Failed tests

org.jboss.as.test.integration.xerces.unit.XercesUsageTestCase(basic-integration-default-web): org.jboss.as.test.integration.xerces.unit.XercesUsageTestCase(basic-integration-default-web).org.jboss.as.test.integration.xerces.unit.XercesUsageTestCase: java.lang.RuntimeException: Could not invoke deployment method: public static org.jboss.shrinkwrap.api.spec.EnterpriseArchive org.jboss.as.test.integration.xerces.unit.XercesUsageTestCase.createDeployment() throws java.io.IOException
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:118)
	... 46 more
Caused by: org.jboss.shrinkwrap.resolver.api.InvalidConfigurationFileException: Found 16 problems while building POM model from /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
1/ [ERROR] Non-resolvable import POM: Failed to resolve POM for org.wildfly:wildfly-preview-test-expansion-bom:35.0.0.Final-SNAPSHOT due to Could not find artifact org.wildfly:wildfly-preview-test-expansion-bom:pom:35.0.0.Final-SNAPSHOT in local-mirror (http://nexus.wildfly.int/nexus/repository/public/) @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
2/ [ERROR] 'dependencies.dependency.version' for org.javassist:javassist:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
3/ [ERROR] 'dependencies.dependency.version' for org.codehaus.plexus:plexus-utils:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
4/ [ERROR] 'dependencies.dependency.version' for org.dom4j:dom4j:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
5/ [ERROR] 'dependencies.dependency.version' for org.apache.directory.server:apacheds-test-framework:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
7/ [ERROR] 'dependencies.dependency.version' for org.jboss.resteasy:resteasy-client-utils:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
8/ [ERROR] 'dependencies.dependency.version' for org.jboss.shrinkwrap.descriptors:shrinkwrap-descriptors-impl-javaee:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
9/ [ERROR] 'dependencies.dependency.version' for org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-depchain:pom is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
10/ [ERROR] 'dependencies.dependency.version' for org.jsoup:jsoup:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
11/ [ERROR] 'dependencies.dependency.version' for org.syslog4j:syslog4j:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
12/ [ERROR] 'dependencies.dependency.version' for org.testcontainers:testcontainers:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
13/ [ERROR] 'dependencies.dependency.version' for org.testcontainers:elasticsearch:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
14/ [ERROR] 'dependencies.dependency.version' for org.wildfly:wildfly-testsuite-shared:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
15/ [ERROR] 'dependencies.dependency.version' for org.wildfly.arquillian:wildfly-arquillian-container-managed:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
16/ [ERROR] 'dependencies.dependency.version' for org.wildfly.arquillian:wildfly-arquillian-protocol-jmx:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml

	at org.jboss.shrinkwrap.resolver.impl.maven.MavenWorkingSessionImpl.loadPomFromFile(MavenWorkingSessionImpl.java:176)
	at org.jboss.shrinkwrap.resolver.impl.maven.task.LoadPomTask.execute(LoadPomTask.java:84)
	at org.jboss.shrinkwrap.resolver.impl.maven.PomlessResolveStageBaseImpl.loadPomFromFile(PomlessResolveStageBaseImpl.java:93)
	at org.jboss.shrinkwrap.resolver.impl.maven.MavenResolverSystemBaseImpl.loadPomFromFile(MavenResolverSystemBaseImpl.java:154)
	at org.jboss.as.test.integration.xerces.unit.XercesUsageTestCase.createDeployment(XercesUsageTestCase.java:74)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	... 48 more


org.jboss.as.test.integration.xerces.ws.unit.XercesUsageInWebServiceTestCase(basic-integration-default-web): org.jboss.as.test.integration.xerces.ws.unit.XercesUsageInWebServiceTestCase(basic-integration-default-web).org.jboss.as.test.integration.xerces.ws.unit.XercesUsageInWebServiceTestCase: java.lang.RuntimeException: Could not invoke deployment method: public static org.jboss.shrinkwrap.api.spec.WebArchive org.jboss.as.test.integration.xerces.ws.unit.XercesUsageInWebServiceTestCase.createWebServiceDeployment() throws java.io.IOException
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:118)
	... 46 more
Caused by: org.jboss.shrinkwrap.resolver.api.InvalidConfigurationFileException: Found 16 problems while building POM model from /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
1/ [ERROR] Non-resolvable import POM: Failed to resolve POM for org.wildfly:wildfly-preview-test-expansion-bom:35.0.0.Final-SNAPSHOT due to Could not find artifact org.wildfly:wildfly-preview-test-expansion-bom:pom:35.0.0.Final-SNAPSHOT in local-mirror (http://nexus.wildfly.int/nexus/repository/public/) @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
2/ [ERROR] 'dependencies.dependency.version' for org.javassist:javassist:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
3/ [ERROR] 'dependencies.dependency.version' for org.codehaus.plexus:plexus-utils:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
4/ [ERROR] 'dependencies.dependency.version' for org.dom4j:dom4j:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
5/ [ERROR] 'dependencies.dependency.version' for org.apache.directory.server:apacheds-test-framework:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
7/ [ERROR] 'dependencies.dependency.version' for org.jboss.resteasy:resteasy-client-utils:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
8/ [ERROR] 'dependencies.dependency.version' for org.jboss.shrinkwrap.descriptors:shrinkwrap-descriptors-impl-javaee:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
9/ [ERROR] 'dependencies.dependency.version' for org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-depchain:pom is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
10/ [ERROR] 'dependencies.dependency.version' for org.jsoup:jsoup:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
11/ [ERROR] 'dependencies.dependency.version' for org.syslog4j:syslog4j:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
12/ [ERROR] 'dependencies.dependency.version' for org.testcontainers:testcontainers:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
13/ [ERROR] 'dependencies.dependency.version' for org.testcontainers:elasticsearch:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
14/ [ERROR] 'dependencies.dependency.version' for org.wildfly:wildfly-testsuite-shared:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
15/ [ERROR] 'dependencies.dependency.version' for org.wildfly.arquillian:wildfly-arquillian-container-managed:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml
16/ [ERROR] 'dependencies.dependency.version' for org.wildfly.arquillian:wildfly-arquillian-protocol-jmx:jar is missing. @ org.wildfly:wildfly-ts-integ-basic:35.0.0.Final-SNAPSHOT, /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/basic/pom.xml

	at org.jboss.shrinkwrap.resolver.impl.maven.MavenWorkingSessionImpl.loadPomFromFile(MavenWorkingSessionImpl.java:176)
	at org.jboss.shrinkwrap.resolver.impl.maven.task.LoadPomTask.execute(LoadPomTask.java:84)
	at org.jboss.shrinkwrap.resolver.impl.maven.PomlessResolveStageBaseImpl.loadPomFromFile(PomlessResolveStageBaseImpl.java:93)
	at org.jboss.shrinkwrap.resolver.impl.maven.MavenResolverSystemBaseImpl.loadPomFromFile(MavenResolverSystemBaseImpl.java:154)
	at org.jboss.as.test.integration.xerces.ws.unit.XercesUsageInWebServiceTestCase.createWebServiceDeployment(XercesUsageInWebServiceTestCase.java:64)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	... 48 more

@bstansberry bstansberry added the hold Do not merge this PR label Dec 15, 2024
@bstansberry
Copy link
Contributor Author

I put the 'hold' label on this because in the joy of refactoring I forgot about #6247, which should take precedence for that piece of this. This is mostly about different things.

I do prefer not changing the current base.name.slot structure of the service names though, mostly because we don't have to and you never know if someone out would be disrupted in some small way by a change. I'll send a PR to @lvydra about that part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
28.x hold Do not merge this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bstansberry @wildfly-ci