calls listDocuments to also get refs to empty documents #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can backup collections that only contain other collections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can backup collections that only contain other collections
the api seems to have added
listDocuments()toCollectionReference(it's not in the documentation that I can see though...), it returns an array of ~DocumentReferences. When youget()one of those, empty documents will haveexists === true`.needs newer version of firebase-admin
looks like there could be some refactoring of the promise code, it's is getting a bit deeply nested.
could also stop logging out the "restore" message when there will be no actual restore
there are 2 broken tests, but they seem to have already been broken...
see:
/issues/52
/issues/40
also (in the other parent fork):
steadyequipment/issues/43
steadyequipment/issues/28
and probably:
steadyequipment/issues/13
steadyequipment/issues/12
and about the restore logging:
/issues/41